New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add cross origin resource sharing by default to blaze server #1134

Merged
merged 3 commits into from Jun 17, 2015

Conversation

Projects
None yet
3 participants
@cpcloud
Member

cpcloud commented Jun 13, 2015

@cpcloud cpcloud self-assigned this Jun 13, 2015

@cpcloud cpcloud added this to the 0.8.1 milestone Jun 13, 2015

@pytest.mark.parametrize('serial', all_formats)
def test_cors_compute(test, serial):

This comment has been minimized.

@cpcloud

cpcloud Jun 13, 2015

Member

@fpliger I couldn't get this test to fail. It passes whether I have CORS enabled or not. Is there something I'm not doing properly to get it to fail when I haven't enabled CORS?

This comment has been minimized.

@fpliger

fpliger Jun 15, 2015

@cpcloud what is the "fail" situation test and the "success" situation test?

@cpcloud cpcloud force-pushed the cpcloud:cors branch from 56e1df6 to 501ce7b Jun 17, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 17, 2015

@fpliger is there an example of something that i can test this against that would trigger the failure on the browser side without this fix?

@hhuuggoo

This comment has been minimized.

Contributor

hhuuggoo commented Jun 17, 2015

you'd have to open up chrome and try to hit the a url from javascript

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 17, 2015

alrighty down the rabbit hole!

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 17, 2015

alrighty i smoked tested this in javascript and i'm able to send requests from another origin, merging

cpcloud added a commit that referenced this pull request Jun 17, 2015

Merge pull request #1134 from cpcloud/cors
WIP: Add cross origin resource sharing by default to blaze server

@cpcloud cpcloud merged commit 81f007e into blaze:master Jun 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cpcloud cpcloud deleted the cpcloud:cors branch Jun 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment