New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow blaze client to disable ssl verification #1170

Merged
merged 3 commits into from Jul 13, 2015

Conversation

Projects
None yet
2 participants
@llllllllll
Member

llllllllll commented Jul 10, 2015

verifies the cert by default; however, we want to disable this

Side note: we might want to think about making ssl the default. There is no downside really and it helps people who might not have thought about the fact that they will be streaming potentially sensitive data over the interned.

note: wait for #1172 and then change the .get to .post

@llllllllll llllllllll added this to the 0.8.3 milestone Jul 10, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

we might want to think about making ssl the default.

isn't that what you've implemented here?

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

or do you mean use https:// by default?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jul 13, 2015

or do you mean use https:// by default?

yeah, this just makes it so that if it uses ssl with a custom cert that it doesn't check the cert. I imagine most production setups will want to serve their data with https.

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

@llllllllll this can be merged after fixing up conflicts and passing

@llllllllll llllllllll force-pushed the quantopian:verify-ssl branch from 8877cb0 to fff7446 Jul 13, 2015

llllllllll added a commit that referenced this pull request Jul 13, 2015

Merge pull request #1170 from quantopian/verify-ssl
allow blaze client to disable ssl verification

@llllllllll llllllllll merged commit 191791d into blaze:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:verify-ssl branch Jul 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment