New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow POST requests on compute.<format> route #1172

Merged
merged 2 commits into from Jul 13, 2015

Conversation

Projects
None yet
4 participants
@cpcloud
Member

cpcloud commented Jul 13, 2015

No description provided.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jul 13, 2015

Not sure what the conda stuff is for, but the post change looks good to me.

Do we need to worry about how this will affect bokeh integration?

@cpcloud cpcloud force-pushed the cpcloud:server-no-get-with-body branch from b39d2bb to dbbbbb0 Jul 13, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

conda stuff was an accident i branched off the wrong branch

@cpcloud cpcloud self-assigned this Jul 13, 2015

@cpcloud cpcloud added this to the 0.8.3 milestone Jul 13, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

cc @bryevdv @fpliger are you guys ok with this change?

@bryevdv

This comment has been minimized.

bryevdv commented Jul 13, 2015

Looks like the BlazeDataSource already uses POST:

https://github.com/bokeh/bokeh/blob/master/bokehjs/src/coffee/source/blaze_data_source.coffee#L31

So should hopefully be ok?

@fpliger

This comment has been minimized.

fpliger commented Jul 13, 2015

Looks like the BlazeDataSource already uses POST:

ah, right. This looks like a safe change.. we can pay particular attention to that and test

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 13, 2015

thanks for the comments guys. merging

cpcloud added a commit that referenced this pull request Jul 13, 2015

Merge pull request #1172 from cpcloud/server-no-get-with-body
Only allow POST requests on compute.<format> route

@cpcloud cpcloud merged commit f0028a2 into blaze:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cpcloud cpcloud deleted the cpcloud:server-no-get-with-body branch Jul 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment