New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of reductions when using a generated leaf from the compute sequence #1198

Merged
merged 5 commits into from Aug 7, 2015

Conversation

Projects
None yet
2 participants
@cpcloud
Member

cpcloud commented Aug 7, 2015

No description provided.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Aug 7, 2015

Was the old name: __sum?

@cpcloud

This comment has been minimized.

Member

cpcloud commented Aug 7, 2015

yes

@cpcloud cpcloud self-assigned this Aug 7, 2015

@cpcloud cpcloud added this to the 0.8.3 milestone Aug 7, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Aug 7, 2015

while that's a valid python identifier, not all system accept this, moreover it exposes an implementation detail

@llllllllll

This comment has been minimized.

Member

llllllllll commented Aug 7, 2015

Gotcha, this looks good then. Want to put an entry in whatsnew to mention the fix?

@cpcloud

This comment has been minimized.

Member

cpcloud commented Aug 7, 2015

ah! thanks for reminding me

@cpcloud

This comment has been minimized.

Member

cpcloud commented Aug 7, 2015

merging on pass

cpcloud added a commit that referenced this pull request Aug 7, 2015

Merge pull request #1198 from cpcloud/fix-naming
Fix naming of reductions when using a generated leaf from the compute sequence

@cpcloud cpcloud merged commit 6ddf310 into blaze:master Aug 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cpcloud cpcloud deleted the cpcloud:fix-naming branch Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment