New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: don't unpack options in schema_concat #1262

Merged
merged 3 commits into from Oct 5, 2015

Conversation

Projects
None yet
2 participants
@llllllllll
Member

llllllllll commented Oct 5, 2015

This was causing some strange dshape stuff in transform:

deltas.dshape dshape("var * {sid: ?int64, asof_date: datetime, timestamp: datetime, value: float64}")
deltas.value.dshape dshape("var * ?float64")

In the full expr, value is not an option type; however, when we pull the column out, it becomes optional. The issue is that value in the base expression is dropping the option

@llllllllll llllllllll force-pushed the quantopian:schema-concat branch from 82d1be9 to 9e83642 Oct 5, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Oct 5, 2015

This was definitely a bug, thanks for fixing!

@llllllllll

This comment has been minimized.

Member

llllllllll commented Oct 5, 2015

Merging on pass

@cpcloud

This comment has been minimized.

Member

cpcloud commented Oct 5, 2015

Roger roger

@llllllllll llllllllll merged commit 9e83642 into blaze:master Oct 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:schema-concat branch Oct 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment