Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional relationals #1292

Merged
merged 4 commits into from Nov 19, 2015

Conversation

@mtydykov
Copy link
Contributor

commented Nov 17, 2015

Modify Arithmetic classes so that operations with optionals result in an optional type and add associated tests.

@cpcloud cpcloud added this to the 0.9.0 milestone Nov 17, 2015

@llllllllll

This comment has been minimized.

Copy link
Member

commented Nov 17, 2015

looks like we need to import pytest

Maya Tydykov
TST: add tests for optionals.
MAINT: fix _dtype property in Not class.

TST: fix tests.

TST: clean up imports.

TST: fix imports
@mtydykov

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2015

Yup, sorry. I removed that mistakenly. It's back now.

@mtydykov mtydykov force-pushed the quantopian:optional-relationals branch from b91f6ba to a40d1a7 Nov 17, 2015

@llllllllll

This comment has been minimized.

Copy link
Member

commented Nov 17, 2015

Can you add a new entry to the whatsnew?

@mtydykov

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2015

Sure - which file to I add it to? For the latest version, there's BASE, LOCAL, and REMOTE. I think those were somehow created automatically, and I'm not sure what to do with them.

@llllllllll

This comment has been minimized.

Copy link
Member

commented Nov 17, 2015

docs/source/whatsnew/0.9.0.txt

@mtydykov

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2015

Done.

Maya Tydykov
DOC: add whatsnew entry.
DOC: fix whatsnew entry.

@mtydykov mtydykov force-pushed the quantopian:optional-relationals branch from 46cd018 to 4efd105 Nov 18, 2015

def test_relations_are_boolean():
assert Gt(x, y).schema == dshape('bool')
@pytest.mark.parametrize('relation_type', Relational.__subclasses__())
@pytest.mark.parametrize('lhs,rhs', product((x, y, d, e, f), repeat=2))

This comment has been minimized.

Copy link
@cpcloud

cpcloud Nov 19, 2015

Member

neat! i didn't realize you could chain these

@cpcloud

This comment has been minimized.

Copy link
Member

commented Nov 19, 2015

i'm going to resolve the merge conflicts here and merge on passing

@cpcloud cpcloud merged commit 4efd105 into blaze:master Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.