New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix issue with `Like` selections on SQL selects. #1373

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Projects
None yet
1 participant
@kwmsmith
Member

kwmsmith commented Dec 31, 2015

Like only worked on ColumnElements in sql.py. This led to
NotImplementedErrors when calling like() on a column of a SQL join for example,
which this commit fixes.

@llllllllll @cpcloud can you take a look?

ping @sandhujasmine

FIX: Fix issue with `Like` selections on SQL selects.
`Like` only worked on `ColumnElement`s in sql.py.  This led to
`NotImplementedError`s when calling `like()` on a column of a SQL join,
which this commit fixes.
@kwmsmith

This comment has been minimized.

Member

kwmsmith commented Dec 31, 2015

Closes #1371

@kwmsmith kwmsmith added this to the 0.9.1 milestone Jan 6, 2016

@kwmsmith

This comment has been minimized.

Member

kwmsmith commented Jan 12, 2016

PR tested and verified by @sandhujasmine. Merging.

kwmsmith added a commit that referenced this pull request Jan 12, 2016

Merge pull request #1373 from kwmsmith/bugfix/compute-like-selectable
FIX: Fix issue with `Like` selections on SQL selects.

@kwmsmith kwmsmith merged commit a2edfbd into blaze:master Jan 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kwmsmith kwmsmith deleted the kwmsmith:bugfix/compute-like-selectable branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment