Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: correct isidentical for interactive symbols backed with nans #1387

Merged

Conversation

@llllllllll
Copy link
Member

commented Jan 14, 2016

Fixes an infinite recursion error that would occur when comparing equality equality against fields of a bound symbol where the resource was an ndarray or ndframe with nans

This goes back to the old behavior of not checking the arrays. This is really slow anyways.

I would really prefer to merge: #1348 over this pr

@llllllllll llllllllll force-pushed the quantopian:isidentical-for-interactive-symbols branch 3 times, most recently from c785f07 to 2e3d4d5 Jan 14, 2016

@llllllllll llllllllll changed the title BUG: correct isidentical for things with non hashable args BUG: correct isidentical for interactive symbols backed with `nan`s Jan 22, 2016

@llllllllll llllllllll changed the title BUG: correct isidentical for interactive symbols backed with `nan`s BUG: correct isidentical for interactive symbols backed with nans Jan 22, 2016

llllllllll added a commit that referenced this pull request Jan 22, 2016

Merge pull request #1387 from quantopian/isidentical-for-interactive-…
…symbols

BUG: correct isidentical for interactive symbols backed with nans

@llllllllll llllllllll merged commit 831116a into blaze:master Jan 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:isidentical-for-interactive-symbols branch Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.