New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete `Data` to `data` rename #1431

merged 7 commits into from Feb 26, 2016


None yet
2 participants

kwmsmith commented Feb 25, 2016

This builds on PR #1421:

  • All calls to Data are replaced with data;
  • Calls to Data are deprecated;
  • InteractiveSymbol is deprecated and replaced by _Data;
  • Calls to data create an instance of _Data;
  • Calls to odo.resource are replaced by throughout the codebase and testsuite.

In version 0.11, the following changes will take place, to complete the transition:

  • InteractiveSymbol will be removed;
  • The _Data class will be renamed Data, and calls to data will create a Data instance;
  • Just like Blaze's expressions, the public API is all lowercase function-like objects, and they create instances of their corresponding classes--join and Join, head and Head, etc.

Richard Postelnik and others added some commits Feb 18, 2016

Complete `Data` -> `data` rename.
Renames the `InteractiveSymbol` class to `_Data`, and deprecates
`InteractiveSymbol`.  In version 0.11, `InteractiveSymbol` will be
removed, and the `_Data` class will be renamed `Data`.

This is all to be consistent with other function / class naming schemes,
that have a lowercase entry point that creates an instance of the
CamelCased class.
Remove calls to `odo.resource`, replace with ``.
`data()` will dispatch to `odo.resource()` when needed.  This change
ensures that many of the edge cases in `data()` are tested.
@@ -41,19 +41,27 @@
class InteractiveSymbol(Symbol):
"""Interactive data.
class _Data(Symbol):

This comment has been minimized.


llllllllll Feb 25, 2016


should we just call this Data to match the other expression/smart constructor pairs?

This comment has been minimized.


kwmsmith Feb 25, 2016


Yes, that's exactly the ultimate intent, and in version 0.11 we'll remove InteractiveSymbol and rename _Data to Data. I made note of this in the whatsnew document.

This comment has been minimized.


llllllllll Feb 25, 2016


Ah, I should read the whole change before commenting; sorry

@kwmsmith kwmsmith referenced this pull request Feb 25, 2016


1358 rename Data to data #1421

kwmsmith added a commit that referenced this pull request Feb 26, 2016

Merge pull request #1431 from kwmsmith/refactor/Data-to-data
Complete `Data` to `data` rename

@kwmsmith kwmsmith merged commit 941c304 into blaze:master Feb 26, 2016

@kwmsmith kwmsmith deleted the kwmsmith:refactor/Data-to-data branch Feb 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment