Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Pandas compute_up() on Broadcast exprs. #1442

Merged
merged 3 commits into from Mar 10, 2016

Conversation

@kwmsmith
Copy link
Member

commented Mar 10, 2016

Adds broadcast tests for Pandas frames / series and Dask dataframes.

Fix bug in Pandas compute_up() on Broadcast exprs.
Adds broadcast tests for Pandas frames / series and Dask dataframes.

@kwmsmith kwmsmith added this to the 0.10 milestone Mar 10, 2016

def test_frame_broadcast():
bcast = broadcast_collect(expr=t.amount * t.id)
result = compute(bcast, df)
assert_series_equal(df.amount * df.id, result)

This comment has been minimized.

Copy link
@llllllllll

llllllllll Mar 10, 2016

Member

can we swap the assertion to make the lhs the result and the rhs the expected? I know that this is equivalent but that pattern is more common

This comment has been minimized.

Copy link
@kwmsmith

kwmsmith Mar 10, 2016

Author Member

Done.

@llllllllll

This comment has been minimized.

Copy link
Member

commented Mar 10, 2016

Thanks for the test coverage, looks good!

kwmsmith added a commit that referenced this pull request Mar 10, 2016

Merge pull request #1442 from kwmsmith/bugfix/broadcast-pandas
Fix bug in Pandas compute_up() on Broadcast exprs.

@kwmsmith kwmsmith merged commit 174293b into blaze:master Mar 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kwmsmith kwmsmith deleted the kwmsmith:bugfix/broadcast-pandas branch Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.