New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge core and blaze pkgs #1451

Merged
merged 8 commits into from Mar 19, 2016

Conversation

Projects
None yet
2 participants
@kwmsmith
Member

kwmsmith commented Mar 18, 2016

To simplify the blaze packaging, we merged the core and blaze packages into one recipe / package. This is consistent with the anaconda distribution of blaze, which is now a single package as well.

kwmsmith added some commits Mar 18, 2016

Merge all.recipe and core.recipe into conda.recipe.
Simplify build process and align with the single anaconda distribution
blaze package.

@kwmsmith kwmsmith added this to the 0.10 milestone Mar 18, 2016

kwmsmith added some commits Mar 18, 2016

@@ -15,31 +15,40 @@ source:
requirements:
build:

This comment has been minimized.

@llllllllll

llllllllll Mar 18, 2016

Member

why do we have any build deps other than python and setuptools?

This comment has been minimized.

@kwmsmith

kwmsmith Mar 18, 2016

Member

That's a good question -- I'll investigate. I knew at one point, but I've since forgotten. It would be good to whittle this list down to a minimum.

This comment has been minimized.

@kwmsmith

kwmsmith Mar 18, 2016

Member

When only enabling python and setuptools, conda build gives me this exception:

RuntimeError: Setuptools downloading is disabled in conda build. Be sure to add all dependencies in the meta.yaml

So unfortunately we have to include all packages in build that are required during the python setup.py install process. :(

This comment has been minimized.

@llllllllll

llllllllll Mar 18, 2016

Member

we don't have any dependencies in our setup.py though, we are not building anything

This comment has been minimized.

@kwmsmith

kwmsmith Mar 18, 2016

Member

We have installation requirements:

If there's a way to consolidate the requirements*.txt files and meta.yaml, I'm all ears -- I hate having duplicated stuff. I haven't found a good way to improve this, however.

This comment has been minimized.

@llllllllll
@kwmsmith

This comment has been minimized.

Member

kwmsmith commented Mar 19, 2016

@llllllllll Unfortunately we have to handle our dependencies differently on windows vs. posix, and we have python version specific constraints as well. We've used conda selectors for this, but that feature isn't supported by setuptools.

I don't have the time in the near future to refactor things so that both setuptools and conda use the same requirements files and handle the platform / python version matrix correctly.

The core of this PR is the merging of the core and all conda recipes, which we've accomplished. I'll make an issue to note the desire to refactor the dependency management.

@llllllllll

This comment has been minimized.

Member

llllllllll commented Mar 19, 2016

That's fine, removing the duplication is nice to have but not required

kwmsmith added a commit that referenced this pull request Mar 19, 2016

@kwmsmith kwmsmith merged commit 6fd5366 into blaze:master Mar 19, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 89.468%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kwmsmith kwmsmith deleted the kwmsmith:merge-core-and-blaze-pkgs branch Mar 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment