New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with to_tree() and slice objects. #1516

Merged
merged 2 commits into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@kwmsmith
Member

kwmsmith commented Jun 2, 2016

Have to change the order of cases in to_tree() to ensure slice
objects are handled before lookups inside the names namespace.

Test updated to exercise this case.

ping @ywang007

Fix a bug with to_tree() and slice objects.
Have to change the order of cases in `to_tree()` to ensure `slice`
objects are handled before lookups inside the `names` namespace.

Test updated to exercise this case.

@kwmsmith kwmsmith added this to the 0.11 milestone Jun 2, 2016

@coveralls

This comment has been minimized.

coveralls commented Jun 2, 2016

Coverage Status

Coverage remained the same at 89.246% when pulling 5fffa4e on kwmsmith:bugfix/to-tree-slice into 21ba90c on blaze:master.

@kwmsmith kwmsmith merged commit 0cca30a into blaze:master Jun 2, 2016

1 check passed

coverage/coveralls Coverage remained the same at 89.246%
Details

@kwmsmith kwmsmith deleted the kwmsmith:bugfix/to-tree-slice branch Jun 2, 2016

@kwmsmith kwmsmith modified the milestones: 0.11, 0.10.2 Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment