New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More DB -> CSV fixes and some additions #199

Merged
merged 18 commits into from May 21, 2015

Conversation

Projects
None yet
1 participant
@cpcloud
Member

cpcloud commented May 15, 2015

  • pass encoding to sniffer
  • test that we can handle headers with quoted field names
  • use transactions with begin when writing to csv
  • Output CSV files always have a header unless we're using MySQL, so change that attr when returning the CSV instance.
  • test that we can handle outputting NULL values to CSV from postgres
  • that that we can read in files with a different encoding

@cpcloud cpcloud self-assigned this May 15, 2015

@cpcloud cpcloud added this to the 0.3.3 milestone May 15, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented May 21, 2015

passing on windows. merging

cpcloud added a commit that referenced this pull request May 21, 2015

Merge pull request #199 from cpcloud/more-sql-csv
More DB -> CSV fixes and some additions

@cpcloud cpcloud merged commit e77922a into blaze:master May 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cpcloud cpcloud deleted the cpcloud:more-sql-csv branch May 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment