Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow schema to be passed in resource #223

Merged
merged 17 commits into from Jun 9, 2015

Conversation

@cpcloud
Copy link
Member

commented Jun 9, 2015

No description provided.

@cpcloud cpcloud self-assigned this Jun 9, 2015

@cpcloud cpcloud added this to the 0.3.3 milestone Jun 9, 2015

@cpcloud cpcloud added the enhancement label Jun 9, 2015

@@ -422,21 +427,52 @@ def append_select_statement_to_sql_Table(t, o, **kwargs):
return t


@resource.register('(.*sql.*|oracle|redshift)(\+\w+)?://.+')
def create_schema(ddl, target, bind, tables=None, state=None, checkfirst=None,

This comment has been minimized.

Copy link
@llllllllll

llllllllll Jun 9, 2015

Member

This is not create_schema but schema_doesnt_exist, no?

This comment has been minimized.

Copy link
@cpcloud

cpcloud Jun 9, 2015

Author Member

Good call. Will change when back from lunch.

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2015

@llllllllll Merge-able?

@llllllllll

This comment has been minimized.

Copy link
Member

commented Jun 9, 2015

lgtm

cpcloud added a commit that referenced this pull request Jun 9, 2015

Merge pull request #223 from cpcloud/schema
Allow schema to be passed in resource

@cpcloud cpcloud merged commit 02c6c9d into blaze:master Jun 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.