Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default of None when going from records to tuples #228

Merged
merged 5 commits into from Jun 20, 2015

Conversation

@cpcloud
Copy link
Member

commented Jun 15, 2015

closes #227

@cpcloud cpcloud self-assigned this Jun 19, 2015

@cpcloud cpcloud added this to the 0.3.3 milestone Jun 19, 2015

@cpcloud cpcloud added the bug label Jun 19, 2015

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2015

@llllllllll can you give this a quick review when you get a chance?

@llllllllll

This comment has been minimized.

Copy link
Member

commented Jun 19, 2015

lgtm! Do you think we should add a test for list[dict] -> ndarray / dataframe? In local testing I was pleased to see that it correctly filled with nan

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2015

yeah, let me add that test

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2015

Merging on pass

cpcloud added a commit that referenced this pull request Jun 20, 2015

Merge pull request #228 from cpcloud/missing-json-to-csv
Add a default of None when going from records to tuples

@cpcloud cpcloud merged commit 2b56485 into blaze:master Jun 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cpcloud cpcloud deleted the cpcloud:missing-json-to-csv branch Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.