strawberry_django_plus.filters.filter makes fields required by default?!

[blueyed]

When using strawberry_django_plus.filters.filter instead of strawberry_django.filter, the annotated fields appear to be required, i.e. activated by default in GraphiQL, and using deprecation_reason causes the schema to validate:

❌ Required input field FooFilter.bar_status cannot be deprecated.

@filter(models.Foo)
class FooFilter:
    bar_status: str = gql.django.field(deprecation_reason="use … instead")

I've seen that | None can be used with the annotation to make it optional, but I think it should be optional by default.

code ref:

strawberry-django-plus/strawberry_django_plus/filters.py

Lines 65 to 92 in 273d906

	@__dataclass_transform__(
	order_default=True,
	field_descriptors=(
	StrawberryField,
	_field,
	node,
	connection,
	field.field,
	field.node,
	field.connection,
	),
	)
	def filter( # noqa:A001
	model: Type[Model],
	*,
	name: Optional[str] = None,
	description: Optional[str] = None,
	directives: Optional[Sequence[object]] = (),
	lookups: bool = False,
	) -> Callable[[_T], _T]:
	return input(
	model,
	name=name,
	description=description,
	directives=directives,
	is_filter="lookups" if lookups else True,
	partial=True,
	)

[bellini666]

Hey @blueyed , are you sure that strawberry_django forthis should work just like strawberry_django forces the type annotation to optional?

I'll take a look over the weekend to check what is strawberry_django_plus doing differently

[blueyed]

are you sure that strawberry_django forthis should work just like strawberry_django forces the type annotation to optional?

Can you please rephrase / fix your question? :)

I cannot really tell though: from my experience filters are optional/gql.UNSET by default, and while it appears to be a nice feature to require them, I do not think this should be the default behavior.

[bellini666]

are you sure that strawberry_django forthis should work just like strawberry_django forces the type annotation to optional?

Can you please rephrase / fix your question? :)

OMG, I started typing something, than changed my mind in the middle and didn't reread what I wrote.

What I meant was to ask is: Are you sure strawberry_django works like that? Because the behaviour here should be the same AFAIK.

I cannot really tell though: from my experience filters are optional/gql.UNSET by default, and while it appears to be a nice feature to require them, I do not think this should be the default behavior.

I agree with you! It is just strange from the typing point of view. But well, if strawberry_django is already doing that (based on the question above), strawberry_django_plus shouldn't be working differently.