New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Build a base build image on install, have custom images 'FROM' that. #277

Closed
cooperaj opened this Issue Nov 6, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@cooperaj
Copy link
Collaborator

cooperaj commented Nov 6, 2017

Perhaps, upon install, abstruse should build a base image containing all the things it needs to function as a build image (everything between the lines). This image should then be shown in the standard images UI as a "special" image that can be rebuilt and edited if the users want.

The "create new image" dialog should show something like

FROM abstruse_base
# The abstruse base image contains all the things we need to provide you with our feature set.

# add your commands here
apt-get install blah

In order to prevent the user accidentally breaking the image (maybe by overriding the CMD) some sanitisation checks should be in place so that when they save they can be prompted that what they're doing may break things (but not disallow those changes as they 'may' know what they're doing i.e. include the 'entry.sh' script in their own scripts)

@jkuri jkuri added this to the 2.0 milestone Nov 6, 2017

@Izak88 Izak88 self-assigned this Nov 7, 2017

@Izak88 Izak88 closed this in f0fdf78 Nov 10, 2017

jkuri added a commit that referenced this issue Nov 10, 2017

jkuri added a commit that referenced this issue Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment