Feature/edward stats #238
Merged
Feature/edward stats #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinvtran
force-pushed
the
feature/edward-stats
branch
5 times, most recently
from
f0c928f
to
3f1dfa1
Compare
dustinvtran
force-pushed
the
feature/edward-stats
branch
from
3f1dfa1
to
aaef0ac
Compare
dustinvtran
force-pushed
the
feature/edward-stats
branch
from
aaef0ac
to
0a568dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wraps all of the internal implementation for distributions using
tf.contrib.distributionsinedward.stats. This makes the internals more robust, faster, and support more distribution methods.There's one confusing point: we still have
rvs()in the distributions, which uses SciPy's standard arguments. All other methods such aslogpmf()/logpdf()now use TensorFlow's standard (if the distribution exists; otherwise it defaults to SciPy's standard).Also this includes minor miscellaneous fixes.
I'm not sure how long we'll keep around
edward.stats. After the modeling language, this library may still be useful for use with the model wrappers.