Fix python3 random import error #324

Merged
merged 3 commits into from Nov 7, 2016

Projects

None yet

2 participants

@dawenl
Member
dawenl commented Nov 7, 2016

This PR acts as a temporary fix to #309. The problem seems to be that with Python 3 inspect.isclass sometimes randomly filters out some of the objects, which causes import error when unit tests try to load these objects. This is by no mean a permanent fix though.

Dawen Liang added some commits Nov 7, 2016
Dawen Liang attempt to fix the imoprt error in test
d04955f
Dawen Liang attempt to fix the import error in test
bb12be3
Dawen Liang temporary fix for random import error in python 3
33a4e9c
@dawenl dawenl added Bug build labels Nov 7, 2016
@dustinvtran
Member

thanks @dawenl.

@dustinvtran dustinvtran merged commit b392b7a into master Nov 7, 2016

2 of 3 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dustinvtran dustinvtran deleted the fix_py3_build branch Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment