Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo in db.Config.MaxLifetime default and removing unused db.DefaultPlanCacheDisabled. #222

Merged
merged 2 commits into from Oct 6, 2020

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 6, 2020

PR Summary

  • Type: Bugfix
  • Intended Change Level: patch

Reviewers:

Reviewers keep the following in mind while reviewing this PR, and provide an assessment of them in your approval comment:

  • Does the "Intended Change Level" above match the actual behavior of this PR?
  • Is this PR following patterns set forth in the package (if modifying a package), or the go-sdk design patterns if implementing a new package from scratch?
  • Does this require a backport to LTS versions? If so ping, let the contributors group know.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #222 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   67.54%   67.55%   +0.01%     
==========================================
  Files         563      563              
  Lines       30436    30438       +2     
==========================================
+ Hits        20557    20562       +5     
+ Misses       8604     8601       -3     
  Partials     1275     1275              
Impacted Files Coverage Δ
db/config.go 89.13% <100.00%> (+0.11%) ⬆️
logger/worker.go 67.44% <0.00%> (+3.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fed1e...6894a15. Read the comment docs.

@dhermes dhermes changed the title Fixing type in db.Config.MaxLifetime default and removing unused db.DefaultPlanCacheDisabled. Fixing typo in db.Config.MaxLifetime default and removing unused db.DefaultPlanCacheDisabled. Oct 6, 2020
Copy link
Contributor

@wcharczuk wcharczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcharczuk wcharczuk merged commit 5bb3dbe into master Oct 6, 2020
@wcharczuk wcharczuk deleted the dhermes/copy-paste-db branch October 6, 2020 18:32
@wcharczuk wcharczuk removed their assignment Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants