Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @dhermes to CODEOWNERS. #227

Merged
merged 1 commit into from Feb 7, 2021
Merged

Adding @dhermes to CODEOWNERS. #227

merged 1 commit into from Feb 7, 2021

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 13, 2020

PR Summary

Also updating CODEOWNERS syntax to use * and putting GitHub handles in alphabetical order.

  • Type: Internal
  • Intended Change Level: patch

Reviewers:

Reviewers keep the following in mind while reviewing this PR, and provide an assessment of them in your approval comment:

  • Does the "Intended Change Level" above match the actual behavior of this PR?
  • Is this PR following patterns set forth in the package (if modifying a package), or the go-sdk design patterns if implementing a new package from scratch?
  • Does this require a backport to LTS versions? If so ping, let the contributors group know.

Also updating CODEOWNERS syntax to use `*` and putting GitHub
handles in alphabetical order.
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files         563      563           
  Lines       30438    30438           
=======================================
  Hits        20559    20559           
  Misses       8603     8603           
  Partials     1276     1276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3609b...dd730e4. Read the comment docs.

@wcharczuk wcharczuk merged commit 8bf081d into master Feb 7, 2021
@wcharczuk wcharczuk deleted the dhermes/CODEOWNERS branch February 7, 2021 17:48
@wcharczuk wcharczuk removed their assignment Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants