New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CachePrefix #83

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@blender
Owner

blender commented Jul 10, 2017

No description provided.

@hlintBot

This comment has been minimized.

Show comment
Hide comment
@hlintBot

hlintBot Jul 10, 2017

3 Warnings
⚠️ src/Lib.hs#L533 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:962:5
⚠️ src/Lib.hs#L533 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension ++ ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9

Why Not

1Combine with src/Lib.hs:580:5
⚠️ src/Utils.hs#L256 - Found Use &&&

1zip
2  (map (repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     frameworkNames)
4  (map _frameworkVersion frameworkNames)

Why Not

1map
2  ((repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     Control.Arrow.&&& _frameworkVersion)
4  frameworkNames

Generated by 🚫 Danger

hlintBot commented Jul 10, 2017

3 Warnings
⚠️ src/Lib.hs#L533 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:962:5
⚠️ src/Lib.hs#L533 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension ++ ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9

Why Not

1Combine with src/Lib.hs:580:5
⚠️ src/Utils.hs#L256 - Found Use &&&

1zip
2  (map (repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     frameworkNames)
4  (map _frameworkVersion frameworkNames)

Why Not

1map
2  ((repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     Control.Arrow.&&& _frameworkVersion)
4  frameworkNames

Generated by 🚫 Danger

@blender blender merged commit 872c904 into develop Jul 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@blender blender deleted the feature/cache-prefix branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment