Docker build + Dockerfile fixes #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMD doesn't actually support environment variables. So IMO, keep it simple and suggest overriding with a mount or with a custom (local) Docker image.
till
commented
Mar 31, 2022
Contributor
Author
till
left a comment
till
left a comment
There was a problem hiding this comment.
Left comments explaining what I was doing. Hope it makes sense. :)
|
|
||
| COPY --from=alpine:latest /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ | ||
| ENTRYPOINT ["/cortex-tenant"] | ||
| CMD ["-config", "$CONFIG_FILE"] |
Contributor
Author
There was a problem hiding this comment.
Pretty sure this never worked. It's not supported in CMD. I figured (and of course I can change it) that it's easier to just override it with a mount or with a custom image.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: macbre/push-to-ghcr@master |
Contributor
Author
There was a problem hiding this comment.
Have to admit I haven't used this one before, but it looked simple enough. It should work with the standard GITHUB_TOKEN that github provides. So no need to setup anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #12