Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more output variables #42

Merged

Conversation

@LukGerman
Copy link
Contributor

LukGerman commented Jan 18, 2019

What

Added task execution role arn, task definition arn and task definition family to the outputs.

Why

To provide ability to use those resources outside of module.

@maartenvanderhoef

This comment has been minimized.

Copy link
Collaborator

maartenvanderhoef commented Jan 18, 2019

Try to do your pull requests with the following setup so it's clear for everyone what the changes are and why it's needed. I'm adding a template for this to the repo!

What

Why

outputs.tf Outdated
}

output "aws_ecs_task_definition_arn" {
value = "${module.ecs_task_definition.aws_ecs_task_definition_arn}"

This comment has been minimized.

Copy link
@maartenvanderhoef

maartenvanderhoef Jan 18, 2019

Collaborator

should be value = "${module.ecs_task_definition_selector.selected_task_definition_for_deployment}"

This comment has been minimized.

Copy link
@LukGerman

LukGerman Jan 21, 2019

Author Contributor

changed

outputs.tf Outdated
@@ -9,3 +9,15 @@ output "ecs_taskrole_name" {
output "lb_target_group_arn" {
value = "${module.alb_handling.lb_target_group_arn}"
}

output "task execution role arn" {

This comment has been minimized.

Copy link
@maartenvanderhoef

maartenvanderhoef Jan 18, 2019

Collaborator

Not sure how this passed travis fmt, have you ran the new code yourself ?

This comment has been minimized.

Copy link
@LukGerman

LukGerman Jan 21, 2019

Author Contributor

fixed, yeah I have ran terraform fmt, terraform init and terraform plan. Is it sufficient?

This comment has been minimized.

Copy link
@maartenvanderhoef

maartenvanderhoef Jan 21, 2019

Collaborator

I see spaces here output "task execution role arn" {

This comment has been minimized.

Copy link
@LukGerman

LukGerman Jan 21, 2019

Author Contributor

Spaces were removed, please look at Files changed tab.

This comment has been minimized.

Copy link
@maartenvanderhoef

maartenvanderhoef Jan 21, 2019

Collaborator

My bad!

LukGerman added 2 commits Jan 21, 2019
@maartenvanderhoef

This comment has been minimized.

Copy link
Collaborator

maartenvanderhoef commented Jan 21, 2019

LG, thanks!

@maartenvanderhoef maartenvanderhoef merged commit 1f77d89 into blinkist:master Jan 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.