Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecation warnings from alb-module #89

Merged
merged 1 commit into from Feb 17, 2020

Conversation

@faester
Copy link
Contributor

faester commented Feb 14, 2020

No description provided.

@faester

This comment has been minimized.

Copy link
Contributor Author

faester commented Feb 14, 2020

When creating services in terraform v 11 we get a bunch of deprecation warnings of the form shown below. Everything works - it is a warning after all - but this fix should get rid of them without changing behavior.

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_custom_listen_host: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_custom_listen_host: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_custom_listen_host_redirect_to_https: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_custom_listen_host_redirect_to_https: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_redirect_to_https: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_redirect_to_https: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_cognito_auth: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_cognito_auth: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_custom_listen_host: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_custom_listen_host: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_custom_listen_host_cognito_auth: "condition.0.field": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead

Warning: module.sfmcsubscription.module.sfmcsubscription.module.service.module.alb_handling.aws_lb_listener_rule.host_based_routing_ssl_custom_listen_host_cognito_auth: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead
@faester faester requested a review from mhvelplund Feb 14, 2020
Copy link
Collaborator

mhvelplund left a comment

LGTM. Docs also state that field is deprecated, and the tests work with Terraform 0.11.14

@mhvelplund mhvelplund merged commit cff9765 into blinkist:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.