fix(adder): make ServiceAccount name match release name

[agaffney]

Summary by CodeRabbit

Release Notes

• Chores

  • Released patch version 0.1.1

• Refactor

  • Enhanced service account naming to use release-specific defaults when explicit names are not provided

[coderabbitai]

Walkthrough

The PR updates the adder Helm chart to introduce a service account name template helper that provides a default value, refactoring existing references to use this helper instead of direct value lookups, and comments out the explicit default in values.yaml.

Changes

Cohort / File(s)	Summary
Chart version charts/adder/Chart.yaml	Version bumped from 0.1.0 to 0.1.1
Service account naming refactor charts/adder/templates/_helpers.tpl, charts/adder/templates/deployment.yaml, charts/adder/templates/serviceaccount.yaml, charts/adder/values.yaml	Added new template helper adder.serviceAccountName that outputs .Values.serviceAccount.name or defaults to <ReleaseName>-sa. Updated deployment and service account templates to use the helper. Commented out explicit serviceAccount.name value in values.yaml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Review the new template helper logic for correctness
• Verify consistent usage of the helper across all templates
• Confirm default behavior matches intended naming convention

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix(adder): make ServiceAccount name match release name" accurately reflects the main changes in the pull request. The changes implement this objective by adding a new template helper (adder.serviceAccountName) that defaults the service account name to <ReleaseName>-sa, updating both the deployment and serviceaccount templates to use this helper, and commenting out the hardcoded value in values.yaml. The title is concise, specific to the adder chart component, clearly indicates the primary change, and avoids vague terminology.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/adder-unique-sa

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e346ba and 06dd63a.

📒 Files selected for processing (5)

• charts/adder/Chart.yaml (1 hunks)
• charts/adder/templates/_helpers.tpl (1 hunks)
• charts/adder/templates/deployment.yaml (1 hunks)
• charts/adder/templates/serviceaccount.yaml (1 hunks)
• charts/adder/values.yaml (1 hunks)

🔇 Additional comments (5)

charts/adder/Chart.yaml (1)

4-4: LGTM! Appropriate version bump.

The patch version increment is appropriate for this non-breaking improvement to the service account naming logic.

charts/adder/values.yaml (1)

29-29: LGTM! Good documentation practice.

Commenting out the explicit name rather than removing it serves as helpful documentation for users who may want to override the default behavior.

charts/adder/templates/_helpers.tpl (1)

21-23: LGTM! Clean helper implementation.

The template helper correctly implements the service account naming logic with an appropriate default that incorporates the release name, following Helm best practices for avoiding resource name collisions across multiple releases.

charts/adder/templates/deployment.yaml (1)

27-27: LGTM! Consistent use of the helper template.

The deployment correctly references the new adder.serviceAccountName helper, ensuring consistent service account naming across the chart.

charts/adder/templates/serviceaccount.yaml (1)

5-5: LGTM! Completes the refactoring.

The ServiceAccount resource now uses the centralized naming helper, ensuring its name matches what the Deployment references and aligns with the release name.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wolf31o2]

Y