New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If MaxBackupCopies = 0 i want no create backups #28

Closed
patocl opened this Issue Nov 20, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@patocl
Copy link

patocl commented Nov 20, 2015

I will like that synthesis not create backup if the flag MaxBackupCopies on synthesys.config is 0 (zero)
When the MaxBackupCopies = 0 the synthesis get a infinite loop

on file located in Synthesis\Generation\CodeDom\CodeDomGenerator.cs
for the method WriteFileWithBackups i will like do this change

        if (File.Exists(path)) // existing version present; make backups as necessary
        {
            uint maxBackups = _parameters.MaxBackupCopies;
            if (maxBackups == 0) return;
@AlexKasaku

This comment has been minimized.

Copy link

AlexKasaku commented Feb 3, 2016

Just encountered this too, we don't need the backups and set this to zero, which created this infinite loop.

kamsar added a commit that referenced this issue Jun 4, 2016

Make "0" mean "no backups"
As requested in #28

Also, because this is a good idea, made the new _default_ zero.
@kamsar

This comment has been minimized.

Copy link
Collaborator

kamsar commented Jun 4, 2016

This will be fixed in the next release.

@patocl

This comment has been minimized.

Copy link

patocl commented Jun 4, 2016

Thanks, I saw your presentation on Sugcon 2016, very good, thanks alot nice
and well xplained all!!!
El 4 jun. 2016 6:29, "Kam Figy" notifications@github.com escribió:

This will be fixed in the next release.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALNmz1-qeJddTJSMAE25pI_QKdY0lHI9ks5qIP8ogaJpZM4GmWwI
.

@kamsar

This comment has been minimized.

Copy link
Collaborator

kamsar commented Jun 21, 2016

Fixed in 8.2.1

@kamsar kamsar closed this Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment