Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix Node 10 error for Object.fromEntries #441

Merged
merged 1 commit into from May 5, 2020

Conversation

is2ei
Copy link

@is2ei is2ei commented May 5, 2020

Type: bug fix

Closes: blitz-js/legacy-framework#483

What are the changes and their implications? ⚙️

Replaced Object.fromEntries with reduce method with callback function.

Checklist

  • Tests added for changes
  • Any added terminal logging uses packages/server/src/log.ts

Breaking change: ??

no

Other information

@is2ei is2ei requested a review from aem as a code owner May 5, 2020 10:06
Copy link
Collaborator

@aem aem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR and tracking down this issue!! I just left a couple of small comments, but overall looks good! Once you update those things I can go ahead and merge

packages/generator/src/utils/fetch-latest-version-for.ts Outdated Show resolved Hide resolved
packages/generator/src/utils/fetch-latest-version-for.ts Outdated Show resolved Hide resolved
@is2ei is2ei force-pushed the avoid-using-fromEntries branch from a10835a to 65b8663 Compare May 5, 2020 14:38
@is2ei
Copy link
Author

is2ei commented May 5, 2020

@aem

Thanks for your comments! Updated:

  • object -> result
  • Added add {} as the first argument to Object.assign.

@flybayer
Copy link
Member

flybayer commented May 5, 2020

Thank you @is2ei!

@all-contributors add @is2ei for code

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @is2ei! 🎉

@flybayer flybayer changed the title Avoid using Object.fromEntries to fix the error Fix Node 10 error for Object.fromEntries May 5, 2020
@flybayer flybayer merged commit 223ab89 into blitz-js:canary May 5, 2020
@Skn0tt
Copy link
Member

Skn0tt commented May 5, 2020

Is there a way to make sure nobody uses v12-Features? Maybe some setting in tsconfig.json?

@flybayer
Copy link
Member

flybayer commented May 6, 2020

@dillondotzip dillondotzip changed the title Fix Node 10 error for Object.fromEntries [legacy-framework] Fix Node 10 error for Object.fromEntries Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] getting "Object.fromEntries is not a function" when retrieving dependencies
4 participants