Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetKey ignores [Shift] (and AltGr) #13

Closed
benkeks opened this issue Feb 3, 2019 · 4 comments
Closed

GetKey ignores [Shift] (and AltGr) #13

benkeks opened this issue Feb 3, 2019 · 4 comments

Comments

@benkeks
Copy link

@benkeks benkeks commented Feb 3, 2019

If I run help/commands/2d_examples/GetKey.bb with the last version of the original Blitz3D, it takes into account whether modifier keys are pressed. For instance, pressing [A] yields 97 (lower-case a), and pressing [Shift]+[A] returns 65 (upper-case A). Compiling the same source with Blitz3D-NG for Windows, both [A] and [Shift]+[A] lead to 97 as output. This seems not to be intended; and as I don't know the users' keyboard layouts, there also is no easy way to implement the modifier key logic manually from within the BB source.

@benkeks
Copy link
Author

@benkeks benkeks commented Feb 4, 2019

(Re-reported by https://youtu.be/DPRK2DCu4-k?t=1h15m51s playing a game that I compiled with Blitz3D-NG.)

@kfprimm
Copy link
Member

@kfprimm kfprimm commented Feb 11, 2019

Hey, thanks for the bug report. I can take a look at this in the next couple of days.

Can you produce a simple code example that demonstrates the problem and paste it here? That will help be address the issue much more quickly.

@benkeks
Copy link
Author

@benkeks benkeks commented Feb 11, 2019

To reproduce the problem, user input is necessary. Example code derived from help/commands/2d_examples/GetKey.bb.

Print "Please press [Shift] and [A] on your keyboard! ..."

While Not value
value = GetKey()
Wend 

Print "GetKey() returned value: " + value + " (which is '" + Chr(value) + "'). (Should return: 65)"
WaitKey()
End
@kfprimm kfprimm closed this in 2fc4fcf Mar 10, 2019
@kfprimm
Copy link
Member

@kfprimm kfprimm commented Mar 10, 2019

@benkeks, looks like it was a simple fix.

For an easy update, just download runtime.d3d7.dll and place it in the bin/ directory of your existing install.

https://ci.appveyor.com/project/kfprimm/blitz3d-ng-gj3xh/build/job/a8d3ljjnnr4kekhg/artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants