Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of files in zip #18

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Jul 11, 2019

Sort list of files in zip
so that blockattack.data builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Also call gzip -n to omit build time from .gz header.

This PR was done while working on reproducible builds for openSUSE.

Sort list of files in zip
so that blockattack.data builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Also call gzip -n to omit build time from .gz header.

@sago007 sago007 merged commit ca85af8 into blockattack:master Jul 12, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sago007

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thank you.
I always wanted it but without an environment to test in, I found it quite difficult to test.

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

If you have other projects and want to test/debug reproducibility, have a look at
https://raw.githubusercontent.com/bmwiedemann/reproducibleopensuse/devel/howtodebug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.