Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH certificate not loading & verifying since bump to 1.19.0 #165

Closed
raiseandfall opened this issue Aug 22, 2019 · 11 comments

Comments

@arunned

This comment has been minimized.

Copy link

commented Aug 22, 2019

I know why it is happening. it is doing a post event in /api/event/certificate at bus-events.js line 36. I do not have this API working. I think previously this was a non blocking error but now it is changed to blocking error.

@raiseandfall

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@raiseandfall

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@arunned I just ran the BV locally on standalone (without the blockcerts.org host specific code), and your certificate is indeed not being loaded.
I can also confirm that :

  • the issue is only happening when display-mode="fullscreen", which was introduced in the last minor version
  • it only affects the ETH certificates
@raiseandfall

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@arunned I found out the problem: your certificate json file is missing the displayHtml field which is not required in the Blockcerts specs, however, the blockcerts-verifier needs it when the attribute display-mode is set to "fullscreen". The blockcerts.org frontpage is using the fullscreen mode since today, which is why you had the issue for the first time today.

We need to think about a fallback solution when display-mode is set to "fullscreen", but the loaded certificate does not have a displayHtml field. How about default to card display mode then?

@lemoustachiste what do you think ?

@arunned

This comment has been minimized.

Copy link

commented Aug 23, 2019

@raiseandfall Yes. you are right. I created another one with displayhtml and it is working. Thanks for quickly identifying the issue. I am glad that the certs we created without displayhtml are not for production. However once we issue production certs, they should always be working and have backward compatibility.

Is there a sandbox for blockcerts.org web where we can test before the code moves to main site?

It is making me nervous if the only way to make it work is to re-issue certificates.

https://pbox.link/C02PD34MFVH9.json

Again, appreciate the fast response.

@raiseandfall

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@arunned We currently don't have a sandbox for blockcerts.org. For this specific issue you wouldn't have to re-issue the certificate, a fallback just needs to be added.
@lemoustachiste and I are currently busy on other matters, but we can look into it first half of next week.
In the meantime, if you are interested to open a PR to address it, feel free to contribute.

Thank you again for reporting this issue!

@AnthonyRonning

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

@arunned I agree that we should maintain backwards compat, but feel free to set up your own verifier if you're using it for production. We cannot guarantee the availability or reliability of blockcerts.org 100% of the time, so if you're doing mission critical stuff, set up your own production instance.

@arunned

This comment has been minimized.

Copy link

commented Aug 23, 2019

@AnthonyRonning Yes. agree. We do have one. Find the link below. It is always best to cross-verify with a 3rd party verifier. I think blockcerts is the only public verifier now. Not sure if there are any other independent verifier site... You can close this issue.

https://pbox.link/verify/index.html?id=C02PD34MFVH9

@lemoustachiste

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@raiseandfall that sounds like a reasonable fallback, especially that full mode would also fail. In the meantime, this is not an error due to the latest release so we need to update blockcerts.org again.

@lemoustachiste

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Falling back to a v1 certificate in fullscreen mode: #170

@lemoustachiste

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

It is now corrected on blockcerts.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.