Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working when certificate contains "displayHtml" #85

Closed
sandoche opened this issue May 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@sandoche
Copy link

commented May 1, 2018

I updated the json template with a displayHtml part to work with the android wallet, but I get this error when trying to sign it:

WARNING - Caught exception trying provider <bound method BlockrIOBroadcaster.broadcast_tx of <cert_issuer.bitcoin.connectors.BlockrIOBroadcaster object at 0x7fbecc918e80>>. Trying another. Exception=Expecting value: line 1 column 1 (char 0)

Here is the json that gives this error: https://api.myjson.com/bins/bwvt3

@sandoche

This comment has been minimized.

Copy link
Author

commented May 8, 2018

I didn't fix this warning, but at least I manage to make it work and generate a valid certificate, by adding displayHtml to @context, cf this PR: blockchain-certificates/cert-tools#27

@sandoche sandoche closed this May 8, 2018

@guix77

This comment has been minimized.

Copy link

commented Jun 28, 2018

It has not been merged and certificates with displayHtml currently do not validate, maybe that issue should be re-opened.

Thanks for your fix Sandoche. I submitted a clean PR with only the necessary changes here : blockchain-certificates/cert-tools#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.