Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguous ethereumTestnet from anchor chains #7

Merged

Conversation

@davidlj95
Copy link

davidlj95 commented Oct 7, 2019

Ethereum testnet is ambiguous as there are multiple ones

More discussion in Blockcerts community forum:

https://community.blockcerts.org/t/merkleproof2017-ethereum-testnet-not-properly-identified/2097

@AnthonyRonning

@davidlj95

This comment has been minimized.

Copy link
Author

davidlj95 commented Oct 7, 2019

PD: Just saw vim added automatically a new EOL in the file

@AnthonyRonning

This comment has been minimized.

Copy link

AnthonyRonning commented Oct 7, 2019

No worries about the EOL thing, thank you! Merging now.

Copy link

AnthonyRonning left a comment

Double checked and doesn't appear we use ethereumTestnet anywhere. Safe to remove, thank you for bringing it to attention and making the PR!

@AnthonyRonning AnthonyRonning merged commit 67b5467 into blockchain-certificates:master Oct 7, 2019
@davidlj95

This comment has been minimized.

Copy link
Author

davidlj95 commented Oct 9, 2019

@AnthonyRonning awesome, thanks!

@davidlj95 davidlj95 deleted the davidlj95:unknown-eth-testnet branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.