Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding displayHtml to @context #27

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
4 participants
@sandoche
Copy link
Contributor

commented May 8, 2018

  • I added displayHtml to @context, without it the signed certificate was invalid
  • I am not sure if the "description" schema is the best fit, but at least now it works!

@guix77 guix77 referenced this pull request Jun 28, 2018

Merged

fix displayHtml #28

@guix77

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

Thanks for your fix Sandoche. I submitted a clean PR with only the necessary changes here : #28

@sandoche

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

Thanks for removing my personal settings I didn't pay attention.

sandoche added some commits Jul 16, 2018

@kimdhamilton

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

Fixed with #28

@chuycepeda

This comment has been minimized.

Copy link

commented Oct 20, 2018

Hey buddies, this fix was amazing... but how will you take it to the additional_per_recipient_fields considering there's an additional "csv_column" element per recipient ??

See... you fixed it for additional_global_fields
additional_global_fields = {"fields": [{"path": "$.displayHtml","value": "<h1>Some html code</h1>"}, {"path": "$.@context","value": ["https://w3id.org/openbadges/v2", "https://w3id.org/blockcerts/v2", {"displayHtml": { "@id": "schema:description" }}]}]}

But... in the case of additional_per_recipient_fields
additional_per_recipient_fields = {"fields":[{"path": "$.nombalu","value": "*|NOMBALU|*","csv_column": "nombalu"}, {"path": "$.@context","value": [{"nombalu": { "@id": "schema:nombalu" }}]}]}

This throws a ....
File "/usr/local/lib/python2.7/dist-packages/cert_tools/instantiate_v2_certificate_batch.py", line 68, in instantiate_recipient cert = jsonpath_helpers.set_field(cert, field['path'], recipient.additional_fields[field['csv_column']]) KeyError: 'csv_column'

I guess I need to add something on the context as well for csv_column but so far no success...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.