New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the function create_iso8601_tz() in helpers.py #34

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ppfish45
Copy link

ppfish45 commented Dec 27, 2018

The origin version of this function will return the local time and "regard" it as the UTC time.

For example, I am in China and currently it's 2018-12-28, 02:03:08 (UTC+8), then the function will return 2018-12-28T02:03:08.278455+00:00. However, the correct result should be 2018-12-27T18:03:08.278455+00:00.

This directly results in the "Transaction occurred at time when issuing address was not considered valid" error in blockcerts.org. To be specific, if a certificate is issued within 8 hours the issuer file is created, it will be rejected by the website because the issuer file will REALLY take effective because the "created time" given by this function is actually 8 hours after the real created time.

@kimdhamilton kimdhamilton self-requested a review Jan 15, 2019

@kimdhamilton
Copy link
Member

kimdhamilton left a comment

Thanks for doing this!

There are some files that should be in .gitignore, and should be reverted from the checkin as well. I commented on one. The others are:

  • sample_data/certificate_templates/*
  • sample_data/rosters/*
  • sample_data/unsigned_certificates/*

Also, there's a file rename I don't understand:
sample_data/unsigned_certificates/.placeholder → cert_tools/issuer_test.json

issuer_name = University of Learning
issuer_id = https://www.blockcerts.org/samples/2.0/issuer-testnet.json
revocation_list=https://www.blockcerts.org/samples/2.0/revocation-list-testnet.json
issuer_url = https://www.ust.hk/

This comment has been minimized.

@kimdhamilton

kimdhamilton Jan 15, 2019

Member

Can you exclude this file from the PR? conf.ini should be in .gitignore (sorry about that!); so if you wanted to make that change too, that would avoid this happening in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment