Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the function create_iso8601_tz() in helpers.py #34
The origin version of this function will return the local time and "regard" it as the UTC time.
For example, I am in China and currently it's 2018-12-28, 02:03:08 (UTC+8), then the function will return 2018-12-28T02:03:08.278455+00:00. However, the correct result should be 2018-12-27T18:03:08.278455+00:00.
This directly results in the "Transaction occurred at time when issuing address was not considered valid" error in blockcerts.org. To be specific, if a certificate is issued within 8 hours the issuer file is created, it will be rejected by the website because the issuer file will REALLY take effective because the "created time" given by this function is actually 8 hours after the real created time.
left a comment
Thanks for doing this!
There are some files that should be in .gitignore, and should be reverted from the checkin as well. I commented on one. The others are:
Also, there's a file rename I don't understand: