New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the function create_iso8601_tz() in helpers.py #35

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@ppfish45
Copy link
Contributor

ppfish45 commented Jan 23, 2019

[This is a reposted pull request]

The origin version of this function will return the local time and "regard" it as the UTC time.

For example, I am in China and currently it's 2018-12-28, 02:03:08 (UTC+8), then the function will return 2018-12-28T02:03:08.278455+00:00. However, the correct result should be 2018-12-27T18:03:08.278455+00:00.

This directly results in the "Transaction occurred at time when issuing address was not considered valid" error in blockcerts.org. To be specific, if a certificate is issued within 8 hours the issuer file is created, it will be rejected by the website because the issuer file will REALLY take effective because the "created time" given by this function is actually 8 hours after the real created time.

@kimdhamilton

This comment has been minimized.

Copy link
Member

kimdhamilton commented Jan 23, 2019

perfect, thanks for the changes!

@kimdhamilton kimdhamilton merged commit 2d8d764 into blockchain-certificates:master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment