Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support fonts #896

Merged
merged 7 commits into from Mar 7, 2018

Conversation

@ditn
Copy link
Contributor

commented Mar 6, 2018

This pull request adds support for Downloadable Fonts, and removes the old font files from the APK. This allows us to not rely on another 3rd party library (as good as Calligraphy is), but also removes unneeded bloat from the app. Instead, Android itself will download and cache the fonts for us.

5.4MB -> 5.0MB, a 7.5% reduction in download size.

Adam Bennett added some commits Mar 5, 2018

Adam Bennett
feat(Downloable Fonts): Initial commit. Unfortunately, two of the fon…
…ts we require aren't available, so this should be revisited in the future
Adam Bennett
Adam Bennett
Adam Bennett
Adam Bennett
Adam Bennett
Adam Bennett

@riaanjvos riaanjvos merged commit 844b2f9 into development Mar 7, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checks Your tests passed on CircleCI!
Details
coverage/coveralls First build on feature/support_fonts at 53.285%
Details

@riaanjvos riaanjvos deleted the feature/support_fonts branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.