From 4e14552d40031d9baf222111114958c980165235 Mon Sep 17 00:00:00 2001 From: schnogz Date: Fri, 1 Mar 2019 14:01:19 -0500 Subject: [PATCH] fix camera staying on after mobile qr code login --- .../src/data/auth/sagas.js | 1 - .../src/modals/Mobile/MobileLogin/index.js | 12 +++--------- .../src/modals/index.js | 3 +-- .../src/scenes/Login/template.js | 5 +---- 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.js b/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.js index 030893ef68d..fd71c3027d8 100644 --- a/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.js +++ b/packages/blockchain-wallet-v4-frontend/src/data/auth/sagas.js @@ -323,7 +323,6 @@ export default ({ api, coreSagas }) => { yield put(actions.alerts.displayError(C.MOBILE_LOGIN_ERROR)) } } - yield put(actions.modals.closeModal()) } const register = function*(action) { try { diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/Mobile/MobileLogin/index.js b/packages/blockchain-wallet-v4-frontend/src/modals/Mobile/MobileLogin/index.js index a55a5dc18e1..5e4c9fb7b9a 100644 --- a/packages/blockchain-wallet-v4-frontend/src/modals/Mobile/MobileLogin/index.js +++ b/packages/blockchain-wallet-v4-frontend/src/modals/Mobile/MobileLogin/index.js @@ -6,22 +6,16 @@ import { isNil, isEmpty } from 'ramda' import * as C from 'services/AlertService' import { actions } from 'data' import modalEnhancer from 'providers/ModalEnhancer' -import MobileLogin from './template.js' +import MobileLogin from './template' class MobileLoginContainer extends React.PureComponent { - constructor (props) { - super(props) - this.handleScan = this.handleScan.bind(this) - this.handleError = this.handleError.bind(this) - } - - handleScan (result) { + handleScan = result => { if (!isNil(result) && !isEmpty(result)) { this.props.authActions.mobileLogin(result) } } - handleError (error) { + handleError = error => { if (isNil(error) && isEmpty(error)) { this.props.alertsActions.displayError(C.MOBILE_LOGIN_SCAN_ERROR) } diff --git a/packages/blockchain-wallet-v4-frontend/src/modals/index.js b/packages/blockchain-wallet-v4-frontend/src/modals/index.js index 18d2714da6f..48ac39f75f6 100644 --- a/packages/blockchain-wallet-v4-frontend/src/modals/index.js +++ b/packages/blockchain-wallet-v4-frontend/src/modals/index.js @@ -39,7 +39,7 @@ import { LockboxConnectionPrompt, LockboxShowXPubs } from './Lockbox' -import { MobileLogin, MobileNumberChange, MobileNumberVerify } from './Mobile' +import { MobileNumberChange, MobileNumberVerify } from './Mobile' import { AirdropReminder, SwapGetStarted, @@ -99,7 +99,6 @@ const Modals = () => ( - diff --git a/packages/blockchain-wallet-v4-frontend/src/scenes/Login/template.js b/packages/blockchain-wallet-v4-frontend/src/scenes/Login/template.js index 7f12caf034d..feeec52545d 100644 --- a/packages/blockchain-wallet-v4-frontend/src/scenes/Login/template.js +++ b/packages/blockchain-wallet-v4-frontend/src/scenes/Login/template.js @@ -25,7 +25,6 @@ import { PasswordBox, TextBox } from 'components/Form' -import Modals from 'modals' import MobileLogin from 'modals/Mobile/MobileLogin' const isSupportedBrowser = @@ -99,9 +98,7 @@ const Login = props => { return ( - - - +