Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a bunch of unchecked casts/compiler warnings #25

Merged
merged 1 commit into from May 18, 2016

Conversation

@loxal
Copy link
Contributor

@loxal loxal commented May 17, 2016

  • interface methods do not need to be explicitly public, they are public by nature
* interface methods do not need to be explicitly public, they are public by nature
@loxal
Copy link
Contributor Author

@loxal loxal commented May 17, 2016

Hey @matsjj,

I’ve created two other code cleanup related & independent PRs. I hope they turn out to be useful :)

Cheers,
Alex

@matsjj
Copy link
Collaborator

@matsjj matsjj commented May 18, 2016

Thanks for going through my code and doing some clean up, really appreciate it! I like people who follow the boy scout rule. ;)

@matsjj matsjj merged commit 5befc2f into blockchain:master May 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loxal
Copy link
Contributor Author

@loxal loxal commented May 18, 2016

@matsjj A nice way to get into a project and understand how it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants