Jonathan Block blockjon

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Correct ... shutdown function will not help when there is a segfault but I believe it would be helpful in almost every other fatal scenario I have …

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Shouldn't PHPUnit register a shutdown function which observes if there is a fatal exception that has been thrown and then emit the unit test file a…

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

1) A dev waits 20 minutes to run PHPUnit. The screen fatals with something like that looks like this just as it's almost finished: ................…

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Assume you see a fatal after 99%, take a look at this screencast and maybe you can get a sense of how this is useful in order to continue from wher…

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

@spriebsch At our shop, we have thousands of tests, hundreds of test files, and dozens of developers of writing tests. We use --filter often and we…

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

@spriebsch If there were some way to keep track of all of the tests which generated a fatal crash, that would be great. I think the problem though …

@blockjon
  • @blockjon ca32331
    Put the composer package name back to phpunit/phpunit
blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Usually when a test fails from a thrown exception, PHPUnit provides the developer with useful information about the failed test and it proceeds by…

blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Ok. I have removed this.

@blockjon
  • @blockjon 2148ed0
    Removed superfluous assignment.
blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Ok done.

@blockjon
blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Ok done.

@blockjon
blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Ok done.

@blockjon
blockjon commented on pull request sebastianbergmann/phpunit#1626
@blockjon

Ok. I have moved this to #1627.

@blockjon
  • @blockjon 35dbf0a
    Removed cached count feature since I created a separate PR for it.
@blockjon
Add option to cache the count of tests since the strategy for the count() function is not efficient.
1 commit with 17 additions and 5 deletions
blockjon created branch lyft-4.1 at lyft/phpunit
@blockjon
Feature percentageskip
4 commits with 111 additions and 6 deletions
@blockjon
  • @blockjon 4286756
    Added defensive coding in order to get tests to pass.
@blockjon
@blockjon
  • @blockjon 6b2ae7d
    Implement a percentage skip feature
blockjon commented on pull request lyft/zf1#1
@blockjon

+1 if it works

blockjon commented on pull request lyft/zf1#1
@blockjon

Or... maybe I'm missing something?

blockjon commented on pull request lyft/zf1#1
@blockjon

On the previous line you are referring to $this->headers and then on the following line just $headers Gotta sort that out

@blockjon

I have that problem too.