Skip to content

Conversation

@zees-dev
Copy link
Collaborator

Context

A caller cannot provide post request data since there is no helper function for the HttpOptions; neither are the struct attributes publicly exported.

Fixes

This PR simply:

  • makes the HttpOptions variables public
  • fixes a typo in the same file
  • applies cargo fmt --all to all files (no code changes)
  • sets default-features = false for the only json dependency; to explicitly reduce compiled code/binary size

@zees-dev zees-dev requested review from Joinhack and dmikey June 20, 2024 14:11
Copy link

@dmikey dmikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@Joinhack Joinhack merged commit 0dbdb5d into main Jun 20, 2024
@zees-dev zees-dev deleted the fix/http-open-post-req-body branch June 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants