Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.0-0.1.0 Refactor | changed the multisim payload to pass the ID to bn-server #184

Closed
wants to merge 9 commits into from

Conversation

julianapeace
Copy link
Contributor

@julianapeace julianapeace commented May 10, 2022

Description

Why
Multisim responses were not returning because the ID was getting lost in bn-server.

How it was fixed
All sim payloads default to an array (even single sims)
And the transaction object is pushed down a layer so that a sample simPayload looks like this

Sample simPayload

simPayload:
id: mr4_SDcGbreMVLwpgSY0K,
[  
  {
    from: '0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B',
    to: '0x7a250d5630b4cf539739df2c5dacb4c659f2488d',
    gas: 332160,
    gasPrice: 0,
    input: '0xfb3bdb4100000000000000000000000000000000000000000000003635c9adc5dea000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000746dff22206ce4e3da
6d7eb4d537398be8f236d600000000000000000000000000000000000000000000000000000000624FD77D0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a
0e5c4f27ead9083c756cc200000000000000000000000094d916873b22c9c1b53695f1c002f78537b9b3b2',
    value: 28981678599856504
  },
  {
    from: '0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B',
    to: '0x7a250d5630b4cf539739df2c5dacb4c659f2488d',
    gas: 332160,
    gasPrice: 0,
    input: '0xfb3bdb4100000000000000000000000000000000000000000000003635c9adc5dea000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000746dff22206ce4e3da
6d7eb4d537398be8f236d600000000000000000000000000000000000000000000000000000000624FD77D0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a
0e5c4f27ead9083c756cc200000000000000000000000094d916873b22c9c1b53695f1c002f78537b9b3b2',
    value: 28981678599856504
  }
]

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

Adamj1232 and others added 9 commits February 4, 2022 14:35
* 4.0.0-0.1.0 : Add fantom network #173

* Add fantom network (fantom-main) to Network type in interfaces.ts  and networks object in defaults.ts

* Update version

* 4.0.0-0.1.1 - Test whether localStorage is accessible before performing operations (#172)

* Update version

* Add gasGwei values

Co-authored-by: Aaron Barnard <abarnard@protonmail.com>
Co-authored-by: Arseniy Ivanov <138289+freeatnet@users.noreply.github.com>
@lnbc1QWFyb24
Copy link
Collaborator

Closing in favor of a different approach.

@lnbc1QWFyb24 lnbc1QWFyb24 deleted the refactor/multi-sim-payload branch June 22, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants