(add) Log 'New Order Created' in Gateway Log on Address Creation #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -521,6 +521,13 @@ public function processOrderHash($order_hash, $blockonomics_currency) | |||
| } | |||
| // Process a new order for the id and blockonomics currency | |||
| $new_order = $this->createNewCryptoOrder($order_info, $blockonomics_currency); | |||
| $log_data = array( | |||
| 'order_id' => $new_order->id_order, | |||
There was a problem hiding this comment.
We save this as id_order, however this matches a WHMCS invoice id.
| $log_data = array( | ||
| 'order_id' => $new_order->id_order, | ||
| 'address' => $new_order->addr, | ||
| 'amount' => $new_order->value, |
There was a problem hiding this comment.
There is no need to log the amount as this can be found on the invoice itself.
DarrenWestwood
approved these changes
Mar 21, 2022
DarrenWestwood
requested changes
Mar 21, 2022
| 'address' => $new_order->addr, | ||
| 'crypto' => $new_order->blockonomics_currency | ||
| ); | ||
| logTransaction('blockonomics', $log_data, 'New Order Created'); |
There was a problem hiding this comment.
Instead of 'blockonomics' as the module name, we should collect it from the gateway variables as in the callback logs:
$gatewayModuleName = 'blockonomics';
// Fetch gateway configuration parameters.
$gatewayParams = getGatewayVariables($gatewayModuleName);
and use as follows:
$gatewayParams['name']
…inside processOrderHash
|
Updated. |
DarrenWestwood
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Gateway log with Status "New Order Created" whenever an order is created. Adding to Gateway Log allows user to search/filter based on Bitcoin Address for Debugging.
Screenshots:
Addresses #120