Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displaying pending transactions #4312

Merged
merged 2 commits into from Jul 5, 2021
Merged

Add displaying pending transactions #4312

merged 2 commits into from Jul 5, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jun 24, 2021

Close #4147

Changelog

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending transactions are not sorted. I suppose we can add sorting by nonce and careation time:

Screenshot 2021-06-25 at 12 17 49

Pending and mined transactions both should be ordered by nonce and time in DESC order. Currently, ordering works separately for each kind. We can have a situation when the transaction is still considered by Blockscout as pending (because of indexer slowness), but it was already mined and the user will see those "fake" pending transactions at the top of their address page obstructing review of mined transactions. This is why I suggest ordering all transactions by nonce and time:

Screenshot 2021-06-25 at 12 20 30

@vbaranov vbaranov self-requested a review July 5, 2021 12:27
@vbaranov vbaranov merged commit a999574 into master Jul 5, 2021
@vbaranov vbaranov deleted the np-add-pending-txs branch July 5, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display pending transactions on address page
2 participants