New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maximum width limitation from app nav on App Mining monthly results page #271

Closed
markmhx opened this Issue Oct 16, 2018 · 2 comments

Comments

Projects
3 participants
@markmhx

markmhx commented Oct 16, 2018

So that the nav is allowed to expand width-wise along with the body content.

See: https://app.co/app-mining/september-2018

Before

screen shot 2018-10-16 at 13 05 32

After

screen shot 2018-10-16 at 13 06 49

@markmhx markmhx added this to Needs design in Launch App Mining via automation Oct 16, 2018

@markmhx markmhx moved this from Needs design to Needs development in Launch App Mining Oct 16, 2018

@aulneau

This comment has been minimized.

Collaborator

aulneau commented Oct 16, 2018

@markmhx I think if we do this here, we should consider doing it throughout the rest of the application.

I think the design and layout of the page breaks down on larger screens, which is why I recommended adding the max-width we have on the rest of the site to these pages:

screen shot 2018-10-16 at 7 16 04 am

It also seems your mock up had a max-width imposed, too! -> https://30a49b69e76343b8be73064ea33b99cc.codepen.website/app-mining/month.html

@markmhx

This comment has been minimized.

markmhx commented Oct 16, 2018

100% agree we should consider doing this across the app. It's really just a question of priority in my mind.

Also I agree this page itself could be improved to format more cleanly within wider viewports. Mainly I would make the right-aligned secondary unit maximum width-ed while letting the left one go infinitely wide. And I would give the table columns more specific styling, namely the Rank column so that it collapses to its content size and perhaps center aligns.

But I'm not sure we need to prioritize this for release. If you think we should, though, I can create guidance.

It also seems your mock up had a max-width imposed, too!

Guilty as charged 🤪Must have sneaked in there somehow...

@hstove hstove moved this from Needs development to Needs review in Launch App Mining Oct 17, 2018

@markmhx markmhx moved this from Needs review to Reviewer approved in Launch App Mining Oct 17, 2018

@aulneau aulneau moved this from Reviewer approved to Done in Launch App Mining Oct 17, 2018

@hstove hstove closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment