Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove maximum width limitation from app nav on App Mining monthly results page #271
@markmhx I think if we do this here, we should consider doing it throughout the rest of the application.
I think the design and layout of the page breaks down on larger screens, which is why I recommended adding the max-width we have on the rest of the site to these pages:
It also seems your mock up had a max-width imposed, too! -> https://30a49b69e76343b8be73064ea33b99cc.codepen.website/app-mining/month.html
100% agree we should consider doing this across the app. It's really just a question of priority in my mind.
Also I agree this page itself could be improved to format more cleanly within wider viewports. Mainly I would make the right-aligned secondary unit maximum width-ed while letting the left one go infinitely wide. And I would give the table columns more specific styling, namely the Rank column so that it collapses to its content size and perhaps center aligns.
But I'm not sure we need to prioritize this for release. If you think we should, though, I can create guidance.
Guilty as charged 🤪Must have sneaked in there somehow...