New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh names infinite loop #101

Merged
merged 2 commits into from Apr 5, 2016

Conversation

Projects
None yet
2 participants
@larrysalibra
Member

larrysalibra commented Apr 4, 2016

refresh_names.py enters an infinite loop when blockstack returns an error.

For example, when blockstack server is indexing the blockchain, bs_client.get_all_names(offset, count) always returns {'error': 'Indexing blockchain}` which the script treats as a single name. The break condition of no new names is never met and the while loops continues forever.

This pull requests checks for an error message, displays the error messages, and breaks out of the loop.

larrysalibra added some commits Apr 4, 2016

@muneeb-ali muneeb-ali merged commit 04583f3 into blockstack:master Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment