Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle network errors #153

Merged
merged 4 commits into from Aug 16, 2019

Conversation

@friedger
Copy link
Collaborator

commented Jul 9, 2019

This PR

  • adds blockstack-sdktest module that uses mockito for offline testing
  • adds better network error handling (in fetchAndroid)
  • fixes #150

@yknl yknl self-requested a review Jul 15, 2019

@yknl

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2019

I'm getting an error when I try to sign in with the demo app.

error: The authResponse parameter is an invalid base64 encoded token
Auth response:
eyJ0e......

Edit: seems to be introduced by feature/authresponse_verification

@friedger

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

This is the relevant check: jsonToken.getString("typ") !== "JWT"
Could you check whether the token contains typ

@friedger

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 14, 2019

@yknl Verification is fixed now.

friedger added some commits Aug 14, 2019

@yknl yknl added this to the DX Q3 Sprint 1 milestone Aug 15, 2019

@yknl

yknl approved these changes Aug 15, 2019

Copy link
Collaborator

left a comment

Looks good now 👍

@yknl yknl merged commit a0b7ca4 into develop Aug 16, 2019

2 checks passed

ci/circleci: test Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.