Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make the default app generator prompt user for choice #67
The default app generator now prompts user for choice:
Additionally, the yeoman-environment is now integrated into the package.json bin script. This now allows non-global usage and a single command.
npx generator-blockstack --react # The above command is equivalent to running: npm -g yo generator-blockstack yo blockstack:react
The above commands referencing
npx blockstack/blockstack-app-generator#feature/change-defaults # or npm install -g npx blockstack/blockstack-app-generator#feature/change-defaults
What is the benefit of showing warnings when generating? We get quite a few which is not confidence-inspiring. For example:
Could we suppress the warnings instead for better user experience? Many of our developers are not super experienced and those warnings can be intimidating.
Yeah I hate these warnings, they are in almost all of our projects as a result of bitcoinjs-lib dependencies.
Hmm, possibly. However,
On a positive note -- the plans I have so far for
@zone117x The prompting system should be tested on Windows and Ubuntu. I attempted some tests in Windows VM but hard to tell if the issues I encountered were related to Windows or the env I was running in. Specifically, arrow keys did not work to navigate the prompts. Though, arrow keys did work in general throughout my VM.
Aborting the interactive prompts resulted in this:
I did use ENTER to take the default React generation in my next test. The npm succeeded with odd errors:
Then, after the
We should be testing this in Windows/Ubuntu as well as Mac OS, this generator should work in all three and produce a generated app the compiles in all three.
It could be the env in one or the other needs to be prettty specific to actually succeeded. I had limited time to do a full test run in Windows and none at all in Ubuntu.
Looks like a problem with your environment. Installation and running works just fine for me with
Windows support is widely considered to be cmd.exe and Powershell, both of which work. Also tested with Ubuntu 18.04.