Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBrowser should generate a Gaia association token when signing in #1733
Comments
hstove
self-assigned this
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
markmhx
commented
Dec 6, 2018
@hstove I'm not sure this issue is strictly required by OKR 5.4, is it? I believe the OKR only calls for public hub support. |
markmhx
unassigned
hstove
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
From GAIA bug review: This is important for when people are installing their own hubs. |
This comment has been minimized.
This comment has been minimized.
Is this something we can address this quarter? |
This comment has been minimized.
This comment has been minimized.
Fixed in #1830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jcnelson commentedNov 28, 2018
•
edited
As we work towards adding support for private, user-owned Gaia hubs, we need to make sure that when the user signs into the application, the Browser generates a Gaia association token and passes it in on the
authResponse
JWT. This is necessary for operating private hubs that only accept writes from the user.Specifically, the call to
makeAuthResponse()
here needs to pass in an association token.You can make an association token using this method:
(While we're at it, the call to
makeAuthResponse()
should also pass in URL to the user's desired Core node).