Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recovery code validation with missing base64 padding char #1850

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@zone117x
Copy link
Member

zone117x commented Feb 26, 2019

Fixes the validation for recovery codes that are 128 characters long and missing the base64 = padding char.

@zone117x zone117x requested review from hstove, aulneau and yknl Feb 26, 2019

@yknl

yknl approved these changes Feb 26, 2019

Copy link
Collaborator

yknl left a comment

Thanks for the quick fix!

@hstove

hstove approved these changes Feb 28, 2019

Copy link
Contributor

hstove left a comment

Awesome find. How did you figure this one out?

@hstove hstove merged commit 3afc557 into develop Feb 28, 2019

7 of 8 checks passed

ci/circleci: test-e2e-account-creation Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-account-recovery Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-login Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.